Make Analyzer crashes a warning #90358
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFixes #78412 @stephentoub - you mentioned:
If new warnings are introduced we can add a NoWarn to the project and file an issue. Agreed that non-deterministic warnings will require undoing this. Hopefully we can track such a thing against an issue and undo it with fixed. To get clean I suppressed this warning and filled the following issues:
|
I don't see any suppressions. Did you maybe miss a commit? |
Right you are 🤦♂️I waited to build clean and filed all the issues but forgot to commit the suppressions. |
|
Looks like there are more failures. |
Yeah I figured. I got a clean Windows Libs build w/ CoreCLR but other flavors need suppressions. |
| @@ -46,7 +46,8 @@ | |||
| <!-- Override InformationalVersion during servicing as it's returned via public api. --> | |||
| <InformationalVersion Condition="'$(PreReleaseVersionLabel)' == 'servicing'">$(ProductVersion)</InformationalVersion> | |||
| <InformationalVersion Condition="'$(StabilizePackageVersion)' == 'true'">$(ProductVersion)</InformationalVersion> | |||
| <NoWarn>$(NoWarn),0419,0649,CA2249,CA1830</NoWarn> | |||
| <!-- AD0001 : https://github.com/dotnet/runtime/issues/90356 --> | |||
| <NoWarn>$(NoWarn),0419,0649,CA2249,CA1830;AD0001</NoWarn> | |||
There was a problem hiding this comment.
Should such a NoWarn be centralized in https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems?
There was a problem hiding this comment.
I considered it but the generator was referenced in each project and it made more sense to put this in the same spot the generator was referenced.
ghost
locked as resolved and limited conversation to collaborators
Fixes #78412
@stephentoub - you mentioned:
If new warnings are introduced we can add a NoWarn to the project and file an issue. Agreed that non-deterministic warnings will require undoing this. Hopefully we can track such a thing against an issue and undo it with fixed.
To get clean I suppressed this warning and filled the following issues:
#90356
#90357